Predict gas filter and mixer BUIs#43712
Open
psykana wants to merge 14 commits intospace-wizards:masterfrom
Open
Predict gas filter and mixer BUIs#43712psykana wants to merge 14 commits intospace-wizards:masterfrom
psykana wants to merge 14 commits intospace-wizards:masterfrom
Conversation
PJBot
added
S: Untriaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Predicts gas filter and mixer GUI for a snappier experience.
Requires space-wizards/RobustToolbox#6515.
Why / Balance
Prediction good, #27042
Technical details
Updated
GasFilterBoundUserInterfaceandGasMixerBoundUserInterfaceto use component states.Updated functions to use
Entity<T>.Media
For some reason I cannot record two clients at the same time with OBS, I'll try again later.
Requirements
Breaking changes
GasFilterComponentandGasMixerComponenthave been moved toShared.Removed
GasFilterBoundUserInterfaceStateandGasMixerBoundUserInterfaceState.Respective BUIs now update automatically.
Changelog
nothing player facing